Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non ascii folder name #72

Merged
merged 7 commits into from Oct 13, 2021
Merged

Handle non ascii folder name #72

merged 7 commits into from Oct 13, 2021

Conversation

eastonsuo
Copy link
Contributor

@eastonsuo eastonsuo commented Oct 11, 2021 •
edited by fcollonval

Fixes #71

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch eastonsuo/jupyter-archive/master

@fcollonval fcollonval changed the title fix #71 Error when downloading an floder not named in English Handle non ascii folder name Oct 12, 2021
fcollonval
fcollonval reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eastonsuo

Would you mind adding a test for that? You could for example modify the names in the following test so that it contains utf-8 characters:

jupyter-archive/jupyter_archive/tests/test_archive_handler.py

Line 72 in 350e0c8

async def test_download(jp_fetch, jp_root_dir, followSymlinks, download_hidden, file_list, format, mode):

fcollonval
fcollonval approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @eastonsuo thanks for adding the test

@fcollonval fcollonval merged commit bb49d4e into jupyterlab-contrib:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when downloading an floder not named in English
2 participants
@eastonsuo @fcollonval