Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force flush buffer to avoid data corruption #85

Merged
merged 1 commit into from Feb 22, 2022
Merged

Force flush buffer to avoid data corruption #85

merged 1 commit into from Feb 22, 2022

Conversation

aidy1991
Copy link
Contributor

@aidy1991 aidy1991 commented Feb 14, 2022 •
edited

Fix #80

As described in #80, the end of the archive file will be corrupted in slow network environment. This happens when the last flush() is called with len(stream_buffer) exceeding stream_max_buffer_size.

This PR prevent archived data corrupting to flush buffer forcibly.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch aidy1991/jupyter-archive/force-flush-buffer

fcollonval
fcollonval approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aidy1991

@fcollonval fcollonval merged commit 023a778 into jupyterlab-contrib:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken archived file with slow network and large data
2 participants
@aidy1991 @fcollonval