Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to prevent an error #92

Merged
merged 2 commits into from Apr 8, 2022

Conversation

kawaidev
Copy link
Contributor

@kawaidev kawaidev commented Apr 8, 2022

Sometimes I got an TypeError on my end, so I fixed it.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Binder 👈 Launch a binder notebook on branch kawaidev/jupyter-archive/minor-fix

lastTwoParts =
'.' + splitName.splice(splitName.length - 2, 2).join('.');
if (firstItem) {
const basename = PathExt.basename(firstItem.path);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next() may return undefined.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kawaidev

@fcollonval fcollonval merged commit d7855cb into jupyterlab-contrib:master Apr 8, 2022
@kawaidev kawaidev deleted the minor-fix branch April 9, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants