Restore datefield react component

jupyterlab-contrib · Jun 11, 2024 · 24af7fa · 24af7fa
1 parent 0031154
commit 24af7fa
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/packages/lab-example/src/index.tsx b/packages/lab-example/src/index.tsx
@@ -14,7 +14,7 @@ import {
   Checkbox,
   Combobox,
   DataGrid,
-  // DateField,
+  DateField,
   Disclosure,
   Divider,
   Listbox,
@@ -290,9 +290,9 @@ function Artwork(props: { dataRef: React.Ref<WebDataGrid> }): JSX.Element {
         <NumberField value="10" onChange={onChange} onInput={onChangeConsole}>
           Number Field Label
         </NumberField>
-        {/*        <DateField value="2021-09-12" onChange={onChange}>
+        <DateField value="2021-09-12" onChange={onChange}>
           Date Field Label
-  </DateField> */}
+        </DateField>
         <div className="jp-FlexColumn">
           <label>Select</label>
           <Select onChange={onChange}>
@@ -319,7 +319,9 @@ function Artwork(props: { dataRef: React.Ref<WebDataGrid> }): JSX.Element {
         </div>
       </div>
       <div className="jp-FlexColumn" style={{ gridColumn: 2 }}>
-        <TextArea>Text Area Label</TextArea>
+        <TextArea onChange={onChangeConsole} onSelect={onConsole}>
+          Text Area Label
+        </TextArea>
         <Slider min={0} max={100} onChange={onChangeConsole}>
           <SliderLabel position="0">0%</SliderLabel>
           <SliderLabel position="50">50%</SliderLabel>

diff --git a/packages/react-components/lib/DateField.d.ts b/packages/react-components/lib/DateField.d.ts
@@ -5,7 +5,7 @@ export type { DateFieldElement };
 export interface DateFieldProps
   extends Omit<
     React.AllHTMLAttributes<HTMLInputElement>,
-    'onChange' | 'onInput'
+    'onChange' | 'onInput' | 'max' | 'min'
   > {
   /**
    * Allows getting a ref to the component instance.
@@ -18,9 +18,6 @@ export interface DateFieldProps
   /** The appearance of the element. */
   appearance?: DateFieldElement['appearance'];
 
-  /** Sets the placeholder value of the element, generally used to provide a hint to the user. */
-  placeholder?: DateFieldElement['placeholder'];
-
   /** Allows associating a https://developer.mozilla.org/en-US/docs/Web/HTML/Element/datalist | datalist to the element by https://developer.mozilla.org/en-US/docs/Web/API/Element/id. */
   list?: DateFieldElement['list'];
 

diff --git a/packages/react-components/lib/index.d.ts b/packages/react-components/lib/index.d.ts
@@ -10,6 +10,7 @@ export * from './Button.js';
 export * from './Card.js';
 export * from './Checkbox.js';
 export * from './Combobox.js';
+export * from './DateField.js';
 export * from './DataGridCell.js';
 export * from './DataGridRow.js';
 export * from './DataGrid.js';

diff --git a/packages/react-components/lib/index.js b/packages/react-components/lib/index.js
@@ -10,6 +10,7 @@ export * from './Button.js';
 export * from './Card.js';
 export * from './Checkbox.js';
 export * from './Combobox.js';
+export * from './DateField.js';
 export * from './DataGridCell.js';
 export * from './DataGridRow.js';
 export * from './DataGrid.js';