Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop fast react wrapper #100

Merged
merged 13 commits into from
Jun 12, 2024
Merged

Drop fast react wrapper #100

merged 13 commits into from
Jun 12, 2024

Conversation

fcollonval
Copy link
Member

fast-react-wrapper is deprecated as it raises bugs.

Use custom-element-react-wrappers for starting the skeleton. But with heavy follow-up customization for typing and ref passing.

@fcollonval fcollonval added the bug Something isn't working label Jun 11, 2024
Copy link

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/fix/change-react-wrapper

@fcollonval fcollonval marked this pull request as ready for review June 12, 2024 13:03
@fcollonval fcollonval merged commit 7b55d5f into main Jun 12, 2024
9 checks passed
@fcollonval fcollonval deleted the fix/change-react-wrapper branch June 12, 2024 13:04
@fcollonval fcollonval mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant