Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize @microsoft/fast-components #80

Merged
merged 26 commits into from
Dec 28, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Dec 20, 2023

This PR internalizes the code from the deprecated package @microsoft/fast-components.

It also:

  • Update the color recipe to use an accentColor and a neutralColor design token easing the change of the theme
  • Adds the components: design-system-provider, disclosure, picker and skeleton.

Fixes #79

Copy link

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/maintenance/internalize-fast-components

@fcollonval fcollonval force-pushed the maintenance/internalize-fast-components branch from b67e872 to 0d69f14 Compare December 24, 2023 13:12
@fcollonval fcollonval added the enhancement New feature or request label Dec 27, 2023
@fcollonval fcollonval marked this pull request as ready for review December 27, 2023 17:17
This reverts commit 72219a3.
@fcollonval fcollonval merged commit 9576e44 into main Dec 28, 2023
6 of 8 checks passed
@fcollonval fcollonval deleted the maintenance/internalize-fast-components branch December 28, 2023 09:39
@jtpio
Copy link
Member

jtpio commented Jan 2, 2024

Is that change temporary, so the warning reported in #79 does not show up in the yarn logs anymore?

If so, is there a long-term plan that would not require to vendor @microsoft/fast-components in this repo?

@fcollonval
Copy link
Member Author

It is not temporary - it is definitive change.

@jtpio
Copy link
Member

jtpio commented Jan 3, 2024

If so, is there a long-term plan that would not require to vendor @microsoft/fast-components in this repo?

And for this question?

Asking to get a better idea of the implications, and what that would mean in terms of maintenance work for maintainers in case this proposal is accepted: jupyterlab/frontends-team-compass#227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fast stack to non-deprecated packages
2 participants