Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up jupyterlab-contrib-bot for releases #42

Closed
jtpio opened this issue Mar 17, 2023 · 4 comments
Closed

Set up jupyterlab-contrib-bot for releases #42

jtpio opened this issue Mar 17, 2023 · 4 comments

Comments

@jtpio
Copy link
Member

jtpio commented Mar 17, 2023

Looks like this org already has a bot account: https://github.com/jupyterlab-contrib-bot

Maybe we could use it to make releases using the Jupyter Releaser v2 workflows?

This would help make releases for the projects under the jupyterlab-contrib GitHub organization.

Things to check:

  • Push access on PyPI
  • npm
  • Admin access on the repos

cc @fcollonval who probably created this account

@jtpio
Copy link
Member Author

jtpio commented Apr 7, 2023

So it looks like the jupyterlab-contrib org already has some secrets at the organization level:

image

Maybe that means we could put the jupyterlab-contrib-bot secrets there, and they could be used from individual repos directly?

Likely ADMIN_GITHUB_TOKEN and NPM_TOKEN could stay at the org level, and each repo could have a scoped PYPI_TOKEN? Or we define a PYPI_TOKEN_MAP at the org level.

@fcollonval
Copy link
Member

fcollonval commented Apr 7, 2023

ADMIN_GITHUB_TOKEN is mine for now (the bot may need to be granted more rights to set a valid admin token; did not check)
NPM_TOKEN is the bot
PYPI_TOKEN is the bot (valid for all PyPI packages)

@jtpio
Copy link
Member Author

jtpio commented Apr 7, 2023

the bot may need to be granted more rights to set and valid admin token; did not check)

Probably we could add the bot as "Admin" on the repos using the releaser v2 and I think it should work.

@fcollonval
Copy link
Member

ADMIN_GITHUB_TOKEN is now the one of the bot as can be seen in https://github.com/jupyterlab-contrib/jupyterlab-vim/releases for example ➡️ closing this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants