-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release permission issues #86
Comments
Thanks @ianhi. There is indeed some effort to ease right managements for all the repos in this org: jupyterlab-contrib/jupyterlab-contrib.github.io#46 In the meantime I have added you to be an admin on the repo, if you would like to try running the workflow again. |
thanks @jtpio we are about to make a new release so I will try it out! |
thakn you! that definitely helped. I was able ot run both workflows. However, there may still be permission issues with tokens. in particular when I ran the publish release workflow it ran into this issue regarding tokens: https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/5719591677/job/15497830782
|
Looks like the workflow seems to be properly configured to use the PyPI trusted publisher and nmp provenance though: jupyterlab-vim/.github/workflows/publish-release.yml Lines 18 to 21 in 78f3d62
|
hmm sadly removing them did not help https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/5729062563/job/15525005353 |
@ianhi I updated the project config on pypi.org to use the trusted publisher mechanism. It should now work. |
Let's do it! @krassowski do you have the permissions to release? In general I think anyone with the permissions on this repo should feel free to release at any point after an improvement has been merged. I don't think there's ever been a formal release policy, but if I had to come up with one it would err pretty far on the side of releasing often. No downstream libraries depend on us (as far as I know) and I can't see much benefit in waiting to bundle multiple changes (as there just aren't that many). So after a bug fix unless there are some related fixes soon to be merged it makes sense to release immediately. |
I have started the new release actions |
Thank you! |
Description
It seems that non-admin users (e.g. me) cannot run the
prep_release
workflow.https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/5708296240
It would be good if all people with commit rights were able to run that workflow and have it succeed. Or is it possible for me to induce the bot (which seems to have permissions) to take action?
not sure who would know more about this. maybe @fcollonval and/or @jtpio seeing the conversation here: jupyterlab-contrib/jupyterlab-contrib.github.io#42
The text was updated successfully, but these errors were encountered: