Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export IFavorites #1

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Export IFavorites #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b8be2
add labextension to gitignore
adriendelsalle Jul 30, 2021
cb6fac1
Fix CI
fcollonval Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"@jupyterlab/ui-components": "^4.0.5",
"@lumino/algorithm": "^2.0.0",
"@lumino/commands": "^2.0.1",
"@lumino/coreutils": "^2.0.1",
"@lumino/signaling": "^2.0.0",
"@lumino/widgets": "^2.0.1"
},
Expand Down
11 changes: 8 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,26 @@ import {
} from './utils';
import { PageConfig } from '@jupyterlab/coreutils';

export { IFavorites } from './token';

const TOOLBAR_CLASS = 'jp-FileBrowser-toolbar';

/**
* Initialization data for the jupyterlab-favorites extension.
*/
const favorites: JupyterFrontEndPlugin<void> = {
const favorites: JupyterFrontEndPlugin<IFavorites> = {
id: PluginIDs.favorites,
autoStart: true,
requires: [IDefaultFileBrowser, IFileBrowserFactory, ISettingRegistry],
provides: IFavorites,
optional: [IMainMenu],
activate: async (
activate: (
app: JupyterFrontEnd,
filebrowser: IDefaultFileBrowser,
factory: IFileBrowserFactory,
settingsRegistry: ISettingRegistry,
mainMenu: IMainMenu
) => {
): IFavorites => {
console.log('JupyterLab extension jupyterlab-favorites is activated!');
const docRegistry = app.docRegistry;
const layout = filebrowser.layout as PanelLayout;
Expand Down Expand Up @@ -213,6 +216,8 @@ const favorites: JupyterFrontEndPlugin<void> = {
execute: () => favoritesManager.clearFavorites(),
label: 'Clear Favorites'
});

return favoritesManager;
}
};

Expand Down
10 changes: 10 additions & 0 deletions src/token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { Token } from '@lumino/coreutils';

export namespace PluginIDs {
export const favorites = 'jupyterlab-favorites';
}
Expand Down Expand Up @@ -32,3 +34,11 @@ export namespace IFavorites {
showWidget?: boolean;
};
}

export const IFavorites = new Token<IFavorites>(
'jupyterlab-favorites:IFavorites'
);

export interface IFavorites {
readonly favorites: IFavorites.Favorite[];
}
3 changes: 2 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ __metadata:
"@jupyterlab/ui-components": ^4.0.5
"@lumino/algorithm": ^2.0.0
"@lumino/commands": ^2.0.1
"@lumino/coreutils": ^2.0.1
"@lumino/signaling": ^2.0.0
"@lumino/widgets": ^2.0.1
"@types/json-schema": ^7.0.11
Expand Down Expand Up @@ -714,7 +715,7 @@ __metadata:
languageName: node
linkType: hard

"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.1.2, @lumino/coreutils@npm:^2.1.2":
"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.1.2, @lumino/coreutils@npm:^2.0.1, @lumino/coreutils@npm:^2.1.2":
version: 2.1.2
resolution: "@lumino/coreutils@npm:2.1.2"
checksum: 7865317ac0676b448d108eb57ab5d8b2a17c101995c0f7a7106662d9fe6c859570104525f83ee3cda12ae2e326803372206d6f4c1f415a5b59e4158a7b81066f
Expand Down
Loading