Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs #27

Merged
merged 1 commit into from Apr 14, 2022
Merged

Add docs #27

merged 1 commit into from Apr 14, 2022

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Apr 14, 2022 •
edited

Fix #24

@martinRenou
Copy link
Member Author

One nice side-effect of this is that the Readthedocs build allows to test PR features/bug fixes!

@martinRenou martinRenou marked this pull request as ready for review April 14, 2022 14:33
@jtpio jtpio added the documentation Improvements or additions to documentation label Apr 14, 2022
jtpio
jtpio approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks!!

@jtpio jtpio merged commit 321156e into jupyterlab-contrib:main Apr 14, 2022
@jtpio
Copy link
Member

jtpio commented Apr 14, 2022

One nice side-effect of this is that the Readthedocs build allows to test PR features/bug fixes!

Yes! That's what it's so convenient to have that JupyterLite + Sphinx + RTD integration to test frontend only lab extensions.

@martinRenou martinRenou deleted the add_docs branch April 14, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Binder and/or JupyterLite demo
2 participants
@martinRenou @jtpio