Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit fileChanged after rename #41

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

hbcarlos
Copy link
Contributor

fixes #40

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jtpio jtpio added the bug Something isn't working label Aug 1, 2022
@jtpio
Copy link
Member

jtpio commented Aug 1, 2022

The windows failure looks odd since the PR doesn't modify css files.

Will have a look.

@jtpio
Copy link
Member

jtpio commented Aug 1, 2022

Ci failure is also happening in #42

@hbcarlos
Copy link
Contributor Author

hbcarlos commented Aug 2, 2022

I rebased on main and squashed @jtpio's commit. The test should pass now.

@martinRenou
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit signal after renaming a file
3 participants