Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binder launch #93

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix binder launch #93

merged 1 commit into from
Jul 25, 2023

Conversation

mahendrapaipuri
Copy link
Collaborator

Add requirements.txt file for binder that sets up jupyterlab>=4. @jtpio This fixes the broken binder launch on main branch as it is using jupyterlab 3.x

@mahendrapaipuri
Add requirements.txt for binder
4a2f042 
We need to ensure that we have JLab 4 in binder environment
@mahendrapaipuri
Copy link
Collaborator Author

It can be tested here -> Binder

jtpio
jtpio approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 4eb59bc into jupyterlab-contrib:main Jul 25, 2023
12 checks passed
@mahendrapaipuri mahendrapaipuri deleted the fix_binder branch September 26, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mahendrapaipuri @jtpio