Skip to content

Commit

Permalink
Add support for notebook 7 (#75)
Browse files Browse the repository at this point in the history
* Add notebook 7 tours

* Add integration test for notebook

* Lint the code

* Fix test execution command

* Try fixing notebook integration tests

* Lint the code

* More robust integration tests

* Lint the code

* Upgrade pkgs

* Fix server configuration for notebook 7

* Upgrade galata

* Fix notebook tour

* Fix selector

* Fix notebook notebook tour

* Fix notebook tour
  • Loading branch information
fcollonval committed Aug 15, 2023
1 parent 4953574 commit 09e01fb
Show file tree
Hide file tree
Showing 12 changed files with 2,424 additions and 2,841 deletions.
61 changes: 59 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ jobs:
jupyter labextension list 2>&1 | grep -ie "jupyterlab-tour.*OK"
python -m jupyterlab.browser_check --no-browser-test
integration-tests:
name: Integration tests
integration-tests-lab:
name: Integration tests for JupyterLab
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -145,6 +145,63 @@ jobs:
ui-tests/test-results*
ui-tests/playwright-report
integration-tests-nb:
name: Integration tests for Notebook
needs: build
runs-on: ubuntu-latest

env:
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/pw-browsers

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Download extension package
uses: actions/download-artifact@v3
with:
name: extension-artifacts

- name: Install the extension
run: |
set -eux
python -m pip install "notebook~=7.0" jupyterlab_tour*.whl
- name: Install dependencies
working-directory: ui-tests
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
run: |
jlpm install
- name: Set up browser cache
uses: actions/cache@v3
with:
path: |
${{ github.workspace }}/pw-browsers
key: ${{ runner.os }}-${{ hashFiles('ui-tests/yarn.lock') }}

- name: Install browser
run: jlpm playwright install chromium
working-directory: ui-tests

- name: Execute integration tests
working-directory: ui-tests
run: |
jlpm playwright test -c playwright-notebook.config.js
- name: Upload Playwright Test report
if: always()
uses: actions/upload-artifact@v3
with:
name: notebook-tour-playwright-tests
path: |
ui-tests/test-results
ui-tests/playwright-report
check_links:
name: Check Links
runs-on: ubuntu-latest
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
"stylelint": "^15.10.1",
"stylelint-config-recommended": "^13.0.0",
"stylelint-config-standard": "^34.0.0",
"stylelint-prettier": "^4.0.0",
"ts-jest": "^29.1.1",
"typescript": "~5.0.4",
"yjs": "^13.5.40"
Expand Down Expand Up @@ -200,8 +199,7 @@
"stylelint": {
"extends": [
"stylelint-config-recommended",
"stylelint-config-standard",
"stylelint-prettier/recommended"
"stylelint-config-standard"
],
"rules": {
"property-no-vendor-prefix": null,
Expand Down
Loading

0 comments on commit 09e01fb

Please sign in to comment.