Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data schema design #22

Closed
fcollonval opened this issue May 10, 2021 · 2 comments · Fixed by #23
Closed

Data schema design #22

fcollonval opened this issue May 10, 2021 · 2 comments · Fixed by #23

Comments

@fcollonval
Copy link
Member

With #17, tours can now be defined from JSON description. But I realize the steps attributes is duplicated:

{
        "type": "object",
        "required": ["id", "label", "steps"],
        "properties": {
          "id": {
            "type": "string",
            "description": "A machine-readble ID to identify this tour, will be prefixed. Should be unique within this document."
          },
          "label": {
            "type": "string",
            "description": "A human-readable name for the tour"
          },
          "hasHelpEntry": {
            "type": "boolean",
            "description": "Whether to add a Help Menu item with the label to launch the tour",
            "default": true
          },
          // HERE the steps
          "steps": {
            "description": "The definition of the steps of a tour",
            "type": "array",
            "items": {
              "$ref": "#/definitions/Step"
            }
          },
          // Steps are also HERE options.steps
          "options": {
            "description": "Other options for the tour",
            "$ref": "#/definitions/Props"
          }
}

@bollwyvl Should we keep only the steps in the options as they are/will be generated from Joyride types?

@fcollonval
Copy link
Member Author

Another possibility would be to expand the options in the tour.

@bollwyvl
Copy link
Contributor

Yeah, sorry I didn't make a note about that.

My thinking was:

  • the command API already had steps...
    • didn't want to break back-compatibility
    • wanted to reuse types/test fixtures
  • the steps...
    • get a separate page in the upstream docs
    • represent where most folks would spend their time configuring
    • would get a separate, dedicated UI
    • is slightly less nested

fcollonval added a commit that referenced this issue May 11, 2021
fcollonval added a commit that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants