Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO: Update installing.md uninstall command #81

Closed
wants to merge 2 commits into from

Conversation

nikisix
Copy link

@nikisix nikisix commented May 26, 2023

No description provided.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch nikisix/jupyterlab-vim/patch-1

@firai firai added the documentation Improvements or additions to documentation label Oct 3, 2023
@firai
Copy link
Collaborator

firai commented Oct 3, 2023

@ianhi @krassowski Should we delete installing.md and mention of "JupyterLab <3", i.e. JupyterLab 2, in README altogether? It seems to me that the duplication of information is cause of this typo.

@krassowski
Copy link
Collaborator

I agree with the idea of deleting it, the less duplication the better.

@firai
Copy link
Collaborator

firai commented Oct 7, 2023

Hi @nikisix, thanks for noticing the typo and submitting the PR! Since the extra installation.md only exists to provide JL 2 extension instructions and since JL 2 is quite old now, we think it may be best to delete this file altogether. I hope you don't mind us modifying your PR to do so.

@firai
Copy link
Collaborator

firai commented Oct 7, 2023

Sorry, I didn't notice that a rebase would be required, which is probably more work than it's worth. I have opened a new PR at #121. Please take a look.

I'll close this PR. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants