Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for attempting to update editor when there was none #95

Merged
merged 2 commits into from Aug 1, 2023
Merged

Fix for attempting to update editor when there was none #95

merged 2 commits into from Aug 1, 2023

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Aug 1, 2023 •
edited

Closes #94

This lead to an uncaught exception breaking application of vim dataset flag on notebooks, and thus breaking the Escape and commands in notebooks opened afterwards.

@krassowski
Fix for attempting to update editor when there was none.
41ecbfc 
This lead to uncaught exception breaking application
of vim dataset flag on notebooks, and thus breaking
the Escape and commands in notebooks opened afterwards.
@krassowski krassowski added the bug Something isn't working label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Binder 👈 Launch a Binder on branch krassowski/jupyterlab-vim/fix-notebook-escape-and-commands

@krassowski krassowski mentioned this pull request Aug 1, 2023
Closed
@ianhi
Copy link
Collaborator

ianhi commented Aug 1, 2023

I think the failing build should be fixed by #96

ianhi
ianhi approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@ianhi ianhi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix and to @firai for all the reports!

merging once evreything passes

@ianhi ianhi merged commit 9aa55aa into jupyterlab-contrib:master Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhi ianhi ianhi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Esc key does not exit insert mode in notebooks opened from file browser or launcher
2 participants
@krassowski @ianhi