Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaid is not work in slideshow #76

Open
SepCode opened this issue Mar 13, 2024 · 4 comments
Open

mermaid is not work in slideshow #76

SepCode opened this issue Mar 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@SepCode
Copy link

SepCode commented Mar 13, 2024

mermaid is not work in slideshow

@SepCode SepCode added the bug Something isn't working label Mar 13, 2024
@djstrong
Copy link

It would be very helpful to support mermaid.

@apohllo
Copy link

apohllo commented Apr 3, 2024

Is there any way we could contribute to this issue? Where should we look, to check why the extension is not working?
Mermaid diagrams were recently integrated with Jupyter Lab, so having them in RISE should be easy to implement. I guess this boil down to calling a method, when a certain type of Markdown code (i.e. ```mermaid) is recognized in the text cell.

@krassowski
Copy link

Mermaid diagrams were added in jupyterlab/jupyterlab#14102. It might be as simple as adding the new packages to https://github.com/jupyterlab-contrib/rise/blob/main/packages/application/package.json and rebuilding but I am not familiar with the codebase here so its just a guess.

@Y3drk
Copy link

Y3drk commented Apr 10, 2024

@krassowski

Mermaid diagrams were added in jupyterlab/jupyterlab#14102. It might be as simple as adding the new packages to https://github.com/jupyterlab-contrib/rise/blob/main/packages/application/package.json and rebuilding but I am not familiar with the codebase here so its just a guess.

Wanted to try that approach but encountered issues when trying to work in development mode (another issue listed on this repo).

Also when I tried forking it the dependencies install failed due to some inconsistency with webpack (no idea what that was about). Anyway after the forced install the build still failed.

The reason for that may or may not be in my setup / me using an npm instead of yarn as they do in project, but either way playing around with it is not so simple and I couldn't confirm your theory.

If you had tried it and had any luck with it I'd appreciate any info from you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants