New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to marked 7.0.2, add mermaidjs 10.3.1 #14102
Conversation
Thanks for making a pull request to jupyterlab! |
🔥 this is my favorite feature from https://github.com/agoose77/jupyterlab-markup and would be 👌 to have in core. |
cf52841
to
a25f9ca
Compare
a25f9ca
to
13cf8fa
Compare
Oops broke syntax highlighting 😊 Update: resolved, screenshot added. |
13cf8fa
to
b7c543a
Compare
bot please update snapshots |
Yeah, I don't know what's going on with the ui screenshots. |
b56e6cd
to
8fcd4d7
Compare
8fcd4d7
to
9f69978
Compare
We already have a list of |
... and This kinda seems like something that could be added to the "jupyterlab": {
"integrity": {
"missing": ["Tokens", "MarkedOptions"],
"unused": ["marked-gfm-heading-id", "marked-mangle"]
}
} |
Binder is also busted again: jupyterhub/repo2docker#1301 Going to let ui tests give me some screenshots, then will change the pin to... something that works. |
Welp, binder got past the build, showing:
|
Merging and doing a release to publish a first version of the new packages. @bollwyvl thanks a lot for the patience 🙇 |
autoStart: true, | ||
optional: [IThemeManager], | ||
provides: IMermaidManager, | ||
activate: (app: JupyterFrontEnd, themes: IThemeManager) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this could have been the following since IThemeManager
is declared as optional:
activate: (app: JupyterFrontEnd, themes: IThemeManager | null) => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #15003
@bollwyvl I love that this is finally merged -- is there any documentation for this extension? Thank you (I have installed it and I see it is installed (it's a brand new venv for me, but the link goes to the main jupyterlab documentation and mermaid isn't in the search results for a documentation search) |
References
jlpm
to yarn 3.4.1 #13875Code changes
marked 7.0.2
marked-mangle
andmarked-gfm-heading-id
to squashdeprecation warningshard failsmermaidjs 10.3.1
default
ordark
)<img>
tag, there's not much it can do other than load external images/styletext/vnd.mermaid
and claim extensions.mmd
and.mermaid
(both supported by GitHub)jp-mermaid-version
and#/metadata/text/vnd.mermaid/version
Mermaid Copy Diagram Source
context item for markdown and MIME itemsUser-facing changes
default
theme with Lightdark
theme with DarkBackwards-incompatible changes
Future Work
graphviz
,pickchr