Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add themes with wavy and dotted underline #53

Merged
merged 1 commit into from Feb 27, 2021
Merged

Add themes with wavy and dotted underline #53

merged 1 commit into from Feb 27, 2021

Conversation

krassowski
Copy link
Collaborator

Fixes #13

demo-themes-opt

ocordes
ocordes approved these changes Feb 27, 2021
View reviewed changes
Copy link
Collaborator

@ocordes ocordes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I‘m used to have a filled box showing me an error, but the wavy or dotted underlines are very good!

@ocordes ocordes merged commit aaaaffb into jupyterlab-contrib:master Feb 27, 2021
@krassowski krassowski deleted the add-themes branch February 28, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocordes ocordes ocordes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use vawy line instead of background decoration?
2 participants
@krassowski @ocordes