Handle multiple spinners (#136)

jupyterlab · Feb 14, 2023 · 4ce5000 · 4ce5000
1 parent 4078882
commit 4ce5000
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/tests/jupyterlab/notebook.spec.ts b/tests/jupyterlab/notebook.spec.ts
@@ -138,6 +138,10 @@ test.describe("JupyterLab Benchmark", () => {
       await page.dblclick(`#filebrowser >> text=${tmpPath}`);
 
       const spinner = page.locator('[role="main"] >> .jp-SpinnerContent');
+      // Ensure there is no hanging document
+      while ((await spinner.count()) > 0) {
+        await spinner.first().waitFor({ state: "hidden" });
+      }
 
       const openTime = await perf.measure(async () => {
         // Open the notebook and wait for the spinner to be hidden
@@ -147,7 +151,8 @@ test.describe("JupyterLab Benchmark", () => {
         ]);
 
         if ((await spinner.count()) > 0) {
-          spinner.waitFor({ state: "hidden" });
+          // They should be only one document
+          await spinner.waitFor({ state: "hidden" });
         }
       });
 
@@ -193,8 +198,8 @@ test.describe("JupyterLab Benchmark", () => {
           page.dblclick(`#filebrowser >> text=${filename}_copy.ipynb`),
         ]);
 
-        if ((await spinner.count()) > 0) {
-          spinner.waitFor({ state: "hidden" });
+        while ((await spinner.count()) > 0) {
+          await spinner.first().waitFor({ state: "hidden" });
         }
       }