Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab Tab Close Performance #69

Open
mlucool opened this issue Aug 4, 2021 · 2 comments
Open

Jupyterlab Tab Close Performance #69

mlucool opened this issue Aug 4, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mlucool
Copy link

mlucool commented Aug 4, 2021

Description

Similar to switching tabs (jupyterlab/jupyterlab#4292) and opening notebooks, closing notebooks is slow.

Reproduce

Open a notebook with 1k cells.

The performance graph looks like this when closing it (all the purple at the bottom is another forced reflow):
image

Expected behavior

It closes even faster than it opens

Context

  • Operating System and version: Linux
  • Browser and version: Chrome
  • JupyterLab version: 3.1.x
@mlucool mlucool added the bug Something isn't working label Aug 4, 2021
@welcome
Copy link

welcome bot commented Aug 4, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval
Copy link
Member

Hey @mlucool

I was looking at analyzing that case. But for me the waterfall is looking quite differently:

image

Ref:

  • Chromium 90 on Debian 11
  • JupyterLab 3.1.10

The test notebook is a 157 identical cells notebook without outputs.

Common cell print 300 times a two-lines string

for x in range(OUTPUT_LENGTH):
    print(f'{PREFIX} {x}')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants