Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Iterate on interfaces, tokens, and UI. #48

Merged
merged 7 commits into from
Oct 15, 2019
Merged

Conversation

afshin
Copy link
Member

@afshin afshin commented Oct 4, 2019

  • The IDebugger interface should only need to expose a mode: IDebugger.Mode and a session: IDebugger.ISession
  • The sidebar plugin should be removed.
  • The main debugger plugin should mount the Debugger#sidebar in the right hand side if mode is set to condensed, otherwise it should mount it in the main area.
  • The Debugger extends BoxPanel class should have an attribute called editors that is a TabPanel of read-only text editors that allow users to add breakpoints.

There are some TODO notes in this PR that also give some guidance. In general, the patterns in @jupyterlab/completer-extension and @jupyterlab/inspector-extension are helpful here. They are slightly different from each other, but both very close to what we want, here.

cc: @KsavinN @LeeTZ @jtpio This is as far as I got. I spent more time refactoring the actual plugin plumbing instead of the tab panel bit, unfortunately. I hope this is enough to go on for you!

@KsavinN KsavinN mentioned this pull request Oct 10, 2019
@KsavinN
Copy link
Collaborator

KsavinN commented Oct 14, 2019

@jtpio @JohanMabille Should we merge this PR? I pick up this branch and done all task without that last one "The Debugger extends BoxPanel class should have an attribute called editors that is a TabPanel of read-only text editors that allow users to add breakpoints.".

Or should I just make new PR?

@jtpio
Copy link
Member

jtpio commented Oct 14, 2019

I pick up this branch and done all task without that last one

Where is it? On your fork?

@KsavinN
Copy link
Collaborator

KsavinN commented Oct 14, 2019

I pick up this branch and done all task without that last one

Where is it? On your fork?

Yes. Link to my branch https://github.com/KsavinN/debugger/tree/panel

@jtpio
Copy link
Member

jtpio commented Oct 14, 2019

OK then let's open a PR here on this repo against master since your branch seems to be based on this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants