This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Set terminateDebuggee to false #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This should fix the following behavior of the kernel restarting when the debugger is stopped:
|
|
Looks like the tests are timing out, similar to jupyterlab/jupyterlab#9362 (comment) |
jtpio
reviewed
Nov 19, 2020
| return { | ||
| line: breakpoint.line, | ||
| verified: breakpoint.verified, | ||
| source: breakpoint.source |
There was a problem hiding this comment.
Ah, looks like this change is needed in this code base, because of this: #556
And the fact they have diverged quite a bit because of the strict null checks in core but not here...
|
Let's get it in once the tests pass so we can cut a new patch release. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping the debugger should not stop the kernel.