This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Send breakpoints to the kernel on breakpointChanged #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
changed the title
jtpio
force-pushed
the
send-breakpoints
branch
from
59c533d
to
3f93e3d
Compare
jtpio
force-pushed
the
send-breakpoints
branch
from
3f93e3d
to
abc4a71
Compare
|
Can you explain how to reproduce the issue you had? I tried your branch and it seems that the breakpoints are sent correctly according to PTVSD logs. |
|
It's probably not related to this change. It looks like the handlers are not removed correctly when switching between notebooks and cells. |
|
Is it ok for you if I merge so that I can iterate? |
|
Sure. We can log this (#89 (comment)) in a separate issue. |
|
yep definitely |
jtpio
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial steps to send the breakpoints to the kernel every time they change in the UI (added or deleted).
This is still a work in progress as there seems to be some issues w.r.t the handlers (messages sent multiple times).
Fixes #43