-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI failing due to puppeteer@3.0.0 #60
Comments
Thanks @fcollonval for opening the issue. Do you think it would be worth applying a fix by pinning |
I'm hesitant to make a new set of releases for this, at the very least I don't have the bandwidth until Wednesday. |
As mentioned in puppeteer/puppeteer#5674, one possible workaround for now is to add the following step to the GitHub Actions workflow: - name: TMP fix - install libgbm1
run: sudo apt install -y libgbm1 |
As per actions/runner-images#732, the upstream Ubuntu image will be updated to add that new dependency. Should we update the repo with the temporary fix or just wait for an update of the image? |
I released JupyterLab 2.1.1 with a pinned version of puppeteer. I tried to run our failing CI build, but it is currently still picking up 2.1.0 in the install step. |
Thanks @blink1073 !! |
Since 2 days, the check browser test is failing due to the usage of puppeteer@3.0.0.
An issue is opened there: puppeteer/puppeteer#5674
The text was updated successfully, but these errors were encountered: