Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to JupyterLab 4 examples #232

Merged
merged 16 commits into from Jun 13, 2023
Merged

Update master to JupyterLab 4 examples #232

merged 16 commits into from Jun 13, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Apr 28, 2023

Upgrade example for JupyterLab 4

Switch to extension template (#229)
Add notifications example (#230)
Add an example package for the use of metadata-form (#208)
Add codemirror extension example (#231)

@diegoPlain
Copy link

Hi @fcollonval, I am using this repo for a couple of months now, and I would like to ask you if this PR is going forward, as right now it will fix the CI & repo, and allow the users to play with these examples.

Do you have any schedule in mind to approve it? Thanks in advance.

@fcollonval
Copy link
Member Author

Hey @diegoPlain this PR will make the 4.0 branch the default main branch. So you can definitely work with the 4.0 branch for now (same if you want to push a PR).

I would like to get #226 done (this requires some upstream fix and a 3.6.x release) as it is a required step towards fixing the document example (failing on 4.0 too).

krassowski and others added 4 commits June 3, 2023 14:38
Switch to extension template (#229)
Add notifications example (#230)
Add an example package for the use of metadata-form (#208)
Add codemirror extension example (#231)

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Florence Haudin <haudin.florence@gmail.com>
Co-authored-by: Nicolas Brichet <nicolas.brichet@quantstack.net>
@fcollonval fcollonval added the enhancement New feature or request label Jun 12, 2023
@fcollonval
Copy link
Member Author

Remaining failures can finally be ignored and we can merge this...

@fcollonval fcollonval merged commit 97d5a2d into main Jun 13, 2023
68 of 75 checks passed
@fcollonval fcollonval deleted the 4.0 branch June 13, 2023 12:37
@ibdafna
Copy link
Member

ibdafna commented Jun 13, 2023

Thank you for maintaining this repo ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants