Remove enableImmutableInstalls: false
#39
Conversation
|
CI will be broken (fix is part of #38) |
jtpio
force-pushed
the
35-should-immutable-installs-be-enabled-by-default
branch
from
6312720
to
69d710a
Compare
|
Rebasing to kick CI. |
| @@ -32,6 +32,9 @@ test('should emit an activation console message', async ({ page }) => { | |||
|
|
|||
| await page.getByRole('button', { name: 'Rename' }).click(); | |||
|
|
|||
| // Close file opened as editor | |||
| await page.activity.closePanel('test.my_type'); | |||
There was a problem hiding this comment.
@jtpio @krassowski I would like your input on this.
With 4.0.5, the page.filebrowser.open(filename) code now fails if a file is opened multiple times (different viewers) as in this case. My question, should it be fixed per test as here or fix upstream by allowing to find any number of panel opened for a given filename?
There was a problem hiding this comment.
(different viewers) as in this case. My question, should it be fixed per test as here or fix upstream by allowing to find any number of panel opened for a given filename?
I would say upstream ideally? Could this also fix jupyterlab/jupyterlab#10969 maybe?
There was a problem hiding this comment.
I opened jupyterlab/jupyterlab#14983
fcollonval
deleted the
35-should-immutable-installs-be-enabled-by-default
branch
Fixes #35
Remove yarn option to be more strict on CI.