Fix migration test (#124)

cleanup
jupyterlab · Sep 5, 2023 · 067fccb · 067fccb
1 parent 0617c6a
commit 067fccb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 18 deletions.
diff --git a/tests/data/npm_builder/myextension/package.json b/tests/data/npm_builder/myextension/package.json
@@ -54,8 +54,7 @@
     "watch:labextension": "jupyter labextension watch ."
   },
   "dependencies": {
-    "@jupyterlab/application": "^3.1.0",
-    "@jupyterlab/settingregistry": "^3.1.0"
+    "@jupyterlab/application": "^3.1.0"
   },
   "devDependencies": {
     "@jupyterlab/builder": "^3.1.0",

diff --git a/tests/data/npm_builder/myextension/src/index.ts b/tests/data/npm_builder/myextension/src/index.ts
@@ -3,31 +3,16 @@ import {
   JupyterFrontEndPlugin
 } from '@jupyterlab/application';
 
-import { ISettingRegistry } from '@jupyterlab/settingregistry';
-
 /**
  * Initialization data for the myextension extension.
  */
 const plugin: JupyterFrontEndPlugin<void> = {
   id: 'myextension:plugin',
   autoStart: true,
-  optional: [ISettingRegistry],
   activate: (
-    app: JupyterFrontEnd,
-    settingRegistry: ISettingRegistry | null
+    app: JupyterFrontEnd
   ) => {
     console.log('JupyterLab extension myextension is activated!');
-
-    if (settingRegistry) {
-      settingRegistry
-        .load(plugin.id)
-        .then(settings => {
-          console.log('myextension settings loaded:', settings.composite);
-        })
-        .catch(reason => {
-          console.error('Failed to load settings for myextension.', reason);
-        });
-    }
   }
 };
 

diff --git a/tests/data/npm_builder/myextension/tsconfig.json b/tests/data/npm_builder/myextension/tsconfig.json
@@ -15,6 +15,7 @@
     "resolveJsonModule": true,
     "outDir": "lib",
     "rootDir": "src",
+    "skipLibCheck": true,
     "strict": true,
     "strictNullChecks": true,
     "target": "es2018",