Fix handling of bool args (#82)

hatch_jupyter_builder/plugin.py

@@ -47,9 +47,9 @@ def initialize(self, version, build_data):
         for key in list(kwargs):
             if key not in available_fields:
                 del kwargs[key]
-        config = JupyterBuildConfig(**kwargs)  # type: ignore[arg-type]
+        config = JupyterBuildConfig(**kwargs)
 
-        should_install_hook = config.install_pre_commit_hook
+        should_install_hook = config.install_pre_commit_hook.lower() == "true"
 
         if version == "editable" and should_install_hook:
             install_pre_commit_hook()

hatch_jupyter_builder/utils.py

@@ -208,10 +208,12 @@ def normalize_cmd(cmd: Union[str, list]) -> List[str]:
     return cmd
 
 
-def normalize_kwargs(kwargs: Mapping[str, str]) -> Dict[str, str]:
+def normalize_kwargs(kwargs: Mapping[str, str]) -> Dict[str, Any]:
     """Normalize the key names in a kwargs input dictionary"""
     result = {}
     for key, value in kwargs.items():
+        if isinstance(value, bool):
+            value = str(value)
         result[key.replace("-", "_")] = value
     return result
 

tests/test_plugin.py

@@ -73,6 +73,12 @@ def foo(target_name, version, foo_bar=None, fizz_buzz=None):
         warnings.simplefilter("ignore")
         assert hook.initialize("editable", {})
 
+    config["optional-editable-build"] = True
+    hook = JupyterBuildHook(tmp_path, config, {}, {}, tmp_path, "wheel")
+    with warnings.catch_warnings():
+        warnings.simplefilter("ignore")
+        assert hook.initialize("editable", {})
+
     del sys.modules["test"]