Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration script fixes #138

Merged
merged 2 commits into from Jan 2, 2024
Merged

Migration script fixes #138

merged 2 commits into from Jan 2, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 14, 2023

  • removes the note about using pipx – the invocation is wrong, and finally, it doesn't work when corrected:
    $ pipx run hatch-jupyter-builder migrate .
    usage: /Users/akx/.local/pipx/.cache/c28885c1d0910f0/bin/python -m hatch_jupyter_builder.migrate [-h] target_dir
    /Users/akx/.local/pipx/.cache/c28885c1d0910f0/bin/python -m hatch_jupyter_builder.migrate: error: unrecognized arguments: .
    
  • fixes a typo that causes Git to say fatal: pathspec '.flake' did not match any files

Copy link

welcome bot commented Dec 14, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the bug Something isn't working label Jan 2, 2024
@blink1073 blink1073 merged commit 1c1e205 into jupyterlab:main Jan 2, 2024
24 of 25 checks passed
Copy link

welcome bot commented Jan 2, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants