Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gpt-4-1106-preview model from openai #540

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Add gpt-4-1106-preview model from openai #540

merged 1 commit into from
Dec 26, 2023

Conversation

jamesjun
Copy link
Contributor

Added OpenAI's "gpt-4-1106-preview" model to ChatOpenAIProvider.models and ChatOpenAINewProvider.models.

@welcome Welcome
Copy link

welcome bot commented Dec 22, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added the enhancement New feature or request label Dec 22, 2023
@krassowski
Copy link
Member

krassowski commented Dec 22, 2023 •
edited

For anyone curious this is also known as "GPT-4 Turbo" (with 128K context) as per https://openai.com/blog/new-models-and-developer-products-announced-at-devday

Edit: maybe we should have a dedicated model_labels mapping in the providers to add human-readable names first and put the identifiers in parentheses?

dlqqq
dlqqq approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesjun Awesome, thanks! 🤗

@dlqqq dlqqq merged commit 5d6b65f into jupyterlab:main Dec 26, 2023
7 of 8 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 26, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@dlqqq
Copy link
Collaborator

dlqqq commented Dec 26, 2023

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Dec 26, 2023
@jamesjun @meeseeksmachine
Backport PR jupyterlab#540: Add gpt-4-1106-preview model from openai
1264228
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 26, 2023
Merged
dlqqq pushed a commit that referenced this pull request Dec 26, 2023
@meeseeksmachine @jamesjun
Backport PR #540: Add gpt-4-1106-preview model from openai (#545)
afb138e 
Co-authored-by: James Jun <jamesjun@fb.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@jamesjun
Add gpt-4-1106-preview model from openai (jupyterlab#540)
eb2f88c 
Co-authored-by: mbox <mbox@mbox.mbox>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesjun @krassowski @dlqqq