Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs installation #679

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Update nodejs installation #679

merged 3 commits into from
Mar 7, 2024

Conversation

giswqs
Copy link
Contributor

@giswqs giswqs commented Mar 6, 2024

The installation instruction with nodejs=20 does not work on my linux machine. Removing the version pin installs nodejs v18.18.2, which works fine with jupyter-ai. The reason is that the latest version of nodejs on the anaconda channel is v18.18.2, while the latest version on the conda-forge channel is v0.20.9. So we either have to remove the nodejs version pin or force it to install from the conda-forge channel. Nodejs on the anaconda channel only has 70K downloads, while it has 7.4M downloads on conda-forge. I would recommend installing nodejs from the conda-forge channel.

conda create -n jupyter-ai python=3.11 nodejs=20

image

conda create -n jupyter-ai python=3.11 nodejs

image

conda create -n jupyter-ai python=3.11 conda-forge::nodejs

image

Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for debugging this issue! Another developer on my team had encountered this but I was not able to reproduce it, since I have conda-forge as my default channel in my local Conda config. I've left a minor suggestion below.

docs/source/contributors/index.md Outdated Show resolved Hide resolved
@dlqqq dlqqq added this to the v2.12.0 milestone Mar 6, 2024
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giswqs Awesome work , thank you!

@dlqqq dlqqq added the documentation Improvements or additions to documentation label Mar 7, 2024
@dlqqq dlqqq merged commit 8842451 into jupyterlab:main Mar 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants