Load persisted vector store by default #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
approved these changes
Apr 26, 2024
dlqqq
force-pushed
the
load-vector-store
branch
from
75b44e7
to
22a8d8a
Compare
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Apr 26, 2024
dlqqq
added a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: david qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701
This change is being made to restore the default behavior of
/learn, where it should reload an existing vector store from disk after the server restarts.In the next major release, we will likely make this behavior configurable while defaulting to
Falsefor security. Alternatively, we can explore other ways of loading the vector store that do not rely on de-pickling.