prefer add_done_callback() over recursive coroutine

jupyterlab · Mar 20, 2024 · 9f55400 · 9f55400
1 parent 43df034
commit 9f55400
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/jupyter_collaboration/rooms.py b/jupyter_collaboration/rooms.py
@@ -242,6 +242,15 @@ def _on_document_change(self, target: str, event: Any) -> None:
             return
 
         self._maybe_save_task = asyncio.create_task(self._maybe_save_document())
+        self._maybe_save_task.add_done_callback(self._maybe_save_done_callback)
+
+    def _maybe_save_done_callback(self, _future):
+        if not self._should_resave:
+            return
+
+        self._should_resave = False
+        self._maybe_save_task = asyncio.create_task(self._maybe_save_document())
+        self._maybe_save_task.add_done_callback(self._maybe_save_done_callback)
 
     async def _maybe_save_document(self) -> None:
         """
@@ -278,10 +287,6 @@ async def _maybe_save_document(self) -> None:
             self._document.dirty = False
             self._emit(LogLevel.INFO, "save", "Content saved.")
 
-            if self._should_resave:
-                self._should_resave = False
-                self._maybe_save_task = asyncio.create_task(self._maybe_save_document())
-
         except asyncio.CancelledError:
             return