Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyncio.Task type for python<=3.8 #143

Merged
merged 1 commit into from
May 2, 2023

Conversation

davidbrochart
Copy link
Collaborator

Fixes #142

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/task_type

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd7ec7c) 0.00% compared to head (c50d910) 0.00%.

❗ Current head c50d910 differs from pull request most recent head 02476fd. Consider uploading reports for the commit 02476fd to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #143   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        452     453    +1     
=====================================
- Misses       452     453    +1     
Impacted Files Coverage Δ
jupyter_collaboration/handlers.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart added bug Something isn't working maintenance labels May 2, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbcarlos hbcarlos merged commit 65a6bc6 into jupyterlab:main May 2, 2023
17 checks passed
@davidbrochart davidbrochart deleted the task_type branch May 2, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on Python 3.8 (bad asyncio typing)
4 participants