Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat subprotocol #167

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Chat subprotocol #167

merged 3 commits into from
Jun 20, 2023

Conversation

hbcarlos
Copy link
Member

Adds a new message type for broadcasting messages and a new API for the global awareness provider to support chat.

@hbcarlos hbcarlos added the enhancement New feature or request label Jun 19, 2023
@hbcarlos hbcarlos requested a review from fcollonval June 19, 2023 10:55
@hbcarlos hbcarlos self-assigned this Jun 19, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupyter-collaboration/rtc-subprotocol

@hbcarlos hbcarlos merged commit a4dfc00 into jupyterlab:main Jun 20, 2023
18 checks passed
@hbcarlos hbcarlos deleted the rtc-subprotocol branch June 20, 2023 07:07
fcollonval
fcollonval reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

I have a couple of post-mortem suggestions.

packages/docprovider/src/awareness.ts Show resolved Hide resolved
packages/docprovider/src/awareness.ts Show resolved Hide resolved
packages/docprovider/src/awareness.ts Show resolved Hide resolved
packages/docprovider/src/tokens.ts Show resolved Hide resolved
jupyter_collaboration/handlers.py Show resolved Hide resolved
packages/docprovider/src/awareness.ts Show resolved Hide resolved
packages/collaboration/package.json Show resolved Hide resolved
packages/docprovider/src/awareness.ts Show resolved Hide resolved
packages/docprovider/src/tokens.ts Show resolved Hide resolved
@SylvainCorlay SylvainCorlay mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval left review comments

Assignees

@hbcarlos hbcarlos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hbcarlos @fcollonval