Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the docprovider destination name to avoid conficts #285

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Rename the docprovider destination name to avoid conficts #285

merged 1 commit into from
Apr 17, 2024

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Apr 16, 2024

Fix the docprovider extension destination path, following #280

Fixes #283

We should probably add some tests (I don't even know how it passed)

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/rename_docprovider_extension

@brichet brichet added the bug Something isn't working label Apr 16, 2024
@brichet brichet mentioned this pull request Apr 16, 2024
Closed
krassowski
krassowski approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brichet!

@brichet
Copy link
Contributor Author

brichet commented Apr 17, 2024 •
edited

The Check Release test seems to be broken on main too.

@davidbrochart
Copy link
Collaborator

Thanks a lot Nicolas!

@davidbrochart davidbrochart merged commit adcde32 into jupyterlab:main Apr 17, 2024
20 of 22 checks passed
@brichet brichet deleted the rename_docprovider_extension branch April 17, 2024 07:35
jzhang20133 pushed a commit to jzhang20133/jupyter-collaboration that referenced this pull request Apr 24, 2024
@brichet
rename the docprovider destination name to avoid conficts (jupyterlab…
58c497a 
…#285)
jzhang20133 pushed a commit to jzhang20133/jupyter-collaboration that referenced this pull request Apr 24, 2024
@brichet
rename the docprovider destination name to avoid conficts (jupyterlab…
746536c 
…#285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No collaborator panel in development mode
3 participants
@brichet @davidbrochart @krassowski