Publish npm packages to @jupyterlab org/scope

[gnestor]

@blink1073 I assume that I need permission to publish to the @jupyterlab scope on npm?

[blink1073]

ping @ellisonbg. Also, our subscription appears to have expired for publishing private packages, which tanked the release this morning. I had to manually publish all of the packages. Ideally lerna would let us publish them publicly the first time, cf lerna/lerna#590.

[ellisonbg]

I have added @gnestor to our org and will get the paid account again.

…

On Fri, Jul 7, 2017 at 10:37 AM, Steven Silvester ***@***.***> wrote: ping @ellisonbg <https://github.com/ellisonbg>. Also, our subscription appears to have expired for publishing private packages, which tanked the release this morning. I had to manually publish all of the packages. Ideally lerna would let us publish them publicly the first time, cf lerna/lerna#590 <lerna/lerna#590>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0PIiwQXsLGJrVhAL5kBJZlqgaWv9ks5sLmzjgaJpZM4OROcv> .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

Or Steve, if these extensions are working could you publish them?

…

On Fri, Jul 7, 2017 at 11:08 AM, Brian Granger ***@***.***> wrote: I have added @gnestor to our org and will get the paid account again. On Fri, Jul 7, 2017 at 10:37 AM, Steven Silvester < ***@***.***> wrote: > ping @ellisonbg <https://github.com/ellisonbg>. Also, our subscription > appears to have expired for publishing private packages, which tanked the > release this morning. I had to manually publish all of the packages. > Ideally lerna would let us publish them publicly the first time, cf > lerna/lerna#590 <lerna/lerna#590>. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#4 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABr0PIiwQXsLGJrVhAL5kBJZlqgaWv9ks5sLmzjgaJpZM4OROcv> > . > -- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub ***@***.*** and ***@***.***

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[blink1073]

In progress (plotly left to do).

[blink1073]

Couldn't publish plotly due to this error:

src/index.tsx(12,25): error TS7016: Could not find a declaration file for module 'plotly.js/lib/core'. '/Users/ssilvester/workspace/jupyter/jupyter-renderers/node_modules/plotly.js/lib/core.js' implicitly has an 'any' type.

[gnestor]

Oh ok, I created a package for the plotly.js type declarations in this repo as a temporary patch until my PR on DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#17783) is merged. Maybe you can help me figure this out:

• The default export plotly.js doesn't play nice with webpack: Webpack support plotly/plotly.js#259
• A workaround is to import one of its submodules (which do not depend on browserify specifically): import * as Plotly from 'plotly.js/lib/core'
• @types/plotly.js doesn't provide types for 'plotly.js/lib/core' module
• I submitted a PR to DefinitelyTyped to provide types for 'plotly.js/lib/core' (simply imported the types from default 'plotly.js'
• This resolved the issue but now this extension depends on an unmerged PR

Given your experience with Typescript, is there a better way to do this? Maybe one that doesn't require a change to DefinitelyTyped? A way to say: "The types for 'plotly.js/lib/core' can be found in @types/plotly.js?"

[blink1073]

I think that PR to DT is reasonable. You could shim the plotly type defs for now by declaring a module like the one below:

declare module "plotly.js/lib/core" {
  export = Plotly;
}

[gnestor]

@blink1073 Where should I put this module declaration? In a typings.d.ts file in the same directory? I tried that and I'm seeing this error: Invalid module name in augmentation. Module 'plotly.js/lib/core' resolves to an untyped module at '/Users/grant/Sites/jupyter/jupyter-renderers/node_modules/plotly.js/lib/core.js', which cannot be augmented.

[blink1073]

Hmm, sounds like it won't work without the restructure then.

[gnestor]

Ok, the @jupyterlab/plotly-extension is ready to publish. @blink1073 should I publish or would you like to? If I can do it, what's your workflow? Just npm publish from the plotly-extension dir? Or can I do it using lerna?

[blink1073]

@gnestor, you should be able to run lerna publish from the repo root. I'd recommend adding a npm run publish command like the one in JLab to make sure everything is current and built. Since @jupyterlab/plotly-extension is a new package, it will be published privately, so you'll have to run npm access public @jupyterlab/plotly-extension after this first publish (cf jupyterlab/jupyterlab#2463).

[gnestor]

Ok, sounds good. I just tried to publish plotly-extension and I got the following error: " You need a paid account to perform this action. For more info, visit: https://www.npmjs.com/private-modules : @jupyterlab/plotly-extension"

[ellisonbg]

Hold a few minutes, I will fix that

…

On Wed, Jul 19, 2017 at 11:36 AM, Grant Nestor ***@***.***> wrote: Ok, sounds good. I just tried to publish plotly-extension and I got the following error: " You need a paid account to perform this action. For more info, visit: https://www.npmjs.com/private-modules : @jupyterlab/plotly-extension" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr0HjTiU8ht9oVcFkdMr8Pk3OxFoMaks5sPkzHgaJpZM4OROcv> .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

OK give it s shot!

…

On Wed, Jul 19, 2017 at 11:42 AM, Brian Granger ***@***.***> wrote: Hold a few minutes, I will fix that On Wed, Jul 19, 2017 at 11:36 AM, Grant Nestor ***@***.***> wrote: > Ok, sounds good. I just tried to publish plotly-extension and I got the > following error: " You need a paid account to perform this action. For more > info, visit: https://www.npmjs.com/private-modules : > @jupyterlab/plotly-extension" > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#4 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABr0HjTiU8ht9oVcFkdMr8Pk3OxFoMaks5sPkzHgaJpZM4OROcv> > . > -- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub ***@***.*** and ***@***.***

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

[gnestor]

Success! https://www.npmjs.com/package/@jupyterlab/plotly-extension

[blink1073]

👏