Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Cert on Windows Installer #648

Closed
NickETH opened this issue Apr 25, 2023 · 10 comments
Closed

Weird Cert on Windows Installer #648

NickETH opened this issue Apr 25, 2023 · 10 comments

Comments

@NickETH
Copy link

NickETH commented Apr 25, 2023

Description

The cert, which is used to sign the window installer can not be verified!
Please do not sign this installer like this.
Either use a cert from a well known vendor, which roots are widely distributed
Or do not sign at all!
A signature like this produces a lot more questions as it is able to answer.

Reproduce

Just download the Windows Installer.
Powershell:
Get-AuthenticodeSignature -FilePath "JupyterLab-Setup-Windows.exe"

@welcome
Copy link

welcome bot commented Apr 25, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill
Copy link

What certificate do you see, and which certification vendors would you prefer be used instead?

@JasonWeill
Copy link

For example, are there other open source projects that you use on your Windows installation that use signed installers? If so, which certification authorities do they use?

@NickETH
Copy link
Author

NickETH commented Apr 25, 2023

You are using a developer cert from Apple. This seems to be self signed.
There is no chain of trust behind this, as on a real cert.
image
You can use a code signing cert from any vendor.
We use one from Digicert e.g.
Thanks

@krassowski
Copy link
Member

I think this is a duplicate of #202 which tracks code signing on Windows (and Mac - this one was done).

@mbektas what is blocking us here? Is there something we could do to unblock this, i.e. is this something we need to take up to the Jupyter EC to get a certificate paid for, or is this a software problem to be solved?

@NickETH
Copy link
Author

NickETH commented Apr 25, 2023

You will definitely need a Code Signing Cert for Windows.
Should be not that expensive for open source (30-80$/y).

@mbektas
Copy link
Member

mbektas commented Apr 26, 2023

@krassowski NumFocus was going to purchase a Windows signing certificate and pass the information to me last time we discussed. We haven't synced on that for a very long time.

@NickETH
Copy link
Author

NickETH commented Apr 28, 2023

Any news on this one?

@mbektas
Copy link
Member

mbektas commented Apr 28, 2023

I am working with NumFOCUS to get a signing certificate purchased.
Is this a blocking issue for you? Our Apple signing certificate is not self-signed and we have been using it to sign macOS application. It turns out our build tool (electron builder) is using it also to sign the Windows binaries.

@JasonWeill
Copy link

Resolving as a duplicate of #202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants