Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX fixes #485

Merged
merged 12 commits into from Sep 5, 2022
Merged

UX fixes #485

merged 12 commits into from Sep 5, 2022

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Sep 1, 2022 •
edited

Addressing UX issues including some reported in #477

  • Fix handling of copy - cut - paste - undo -redo keyboard shortcuts in native popup dialogs
  • Fix handling of Esc key clicks on popup dialogs
  • Close application when window is closed
  • Remove spellcheck from python path input
  • Disable refreshing embedded browser
  • Hide unused menu items on macOS app menu
  • Patch for index.html shown as app window title
  • Add option to disable auto-updates on macOS

auto-updates-disabled

auto-updates-enabled

@mbektas mbektas marked this pull request as draft September 1, 2022 20:50
@mbektas mbektas marked this pull request as ready for review September 2, 2022 15:25
krassowski
krassowski reviewed Sep 2, 2022
View reviewed changes
src/main/shortcuts.ts Outdated Show resolved Hide resolved
@mbektas mbektas marked this pull request as draft September 3, 2022 08:43
krassowski
krassowski reviewed Sep 3, 2022
View reviewed changes
src/main/shortcuts.ts Outdated Show resolved Hide resolved
mbektas and others added 2 commits September 3, 2022 09:38
@mbektas
make it optional to auto install updates on mac
baf71a3
@mbektas @krassowski
Update src/main/shortcuts.ts
e517e12 
remove unused reload method

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@mbektas mbektas marked this pull request as ready for review September 4, 2022 04:46
krassowski
krassowski approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@mbektas mbektas merged commit 23e0a49 into jupyterlab:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbektas @krassowski