Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to configure Ctrl + W behavior #606

Merged
merged 1 commit into from Mar 9, 2023

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Mar 8, 2023

fixes #436
ctrl_w_behavior

@mbektas mbektas requested a review from krassowski March 8, 2023 06:35
@mbektas mbektas merged commit 6d31312 into jupyterlab:master Mar 9, 2023
@mbektas mbektas mentioned this pull request Mar 15, 2023
@ltalirz
Copy link

ltalirz commented Mar 22, 2023

Just out of curiosity: do you think it would be possible to get something like this to work also in the browser version of Jupyterlab?

Ctrl+W is a very common shortcut in the bash terminal (delete previous word), and I cannot count the number of times I have accidentally closed the jupyterlab tab.

I know there are web sites that manage to pop up a dialogue when the user tries to close them; could this be possible in jupyterlab as well?

@seapanda85
Copy link

@mbektas

Thanks a lot for the update! I've been really looking forward to the fix. Can I ask a really simple question? I'm following #606 but I can't find the setting in my JupyterLab-Desktop. I'm using Version 3.6.2-1 (3.6.2-1). See below for screenshots of my "Advanced Settings Editor" under "Settings".

Screen Shot 2023-03-31 at 1 04 27 PM

I searched for "Bahavior" in settings but couldn't find it either.
Screen Shot 2023-03-31 at 1 06 08 PM

Could you please let me know where to find the setting for this?

@seapanda85
Copy link

@mbektas

Thanks a lot for the update! I've been really looking forward to the fix. Can I ask a really simple question? I'm following #606 but I can't find the setting in my JupyterLab-Desktop. I'm using Version 3.6.2-1 (3.6.2-1). See below for screenshots of my "Advanced Settings Editor" under "Settings".

Screen Shot 2023-03-31 at 1 04 27 PM

I searched for "Bahavior" in settings but couldn't find it either. Screen Shot 2023-03-31 at 1 06 08 PM

Could you please let me know where to find the setting for this?

Never mind. Found it!

@mbektas mbektas mentioned this pull request Apr 2, 2023
@AnilRh
Copy link

AnilRh commented Apr 2, 2023

@mbektas Where did you find it? I see "Close Tab" and "Close and Shutdown" in the Keyboard shortcuts section, but neither of those are mapped to Command+W.

@mbektas
Copy link
Member Author

mbektas commented Apr 2, 2023

@AnilRh it is in Settings dialog which you can access from menu button (hamburger icon) on top right of any session window.
setings menu

@AnilRh
Copy link

AnilRh commented Apr 2, 2023

Thanks @mbektas - I think it would have taken me quite some time to find that menu! Hamburgers and Macs don't go well together ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable ctrl+w closing the entire app
4 participants