Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python env management UI and env selector popup updates #742

Merged
merged 62 commits into from
Jan 25, 2024

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Dec 26, 2023

  • Introduces Python environment management UI to manage existing environments and create new ones
  • Create a new Python env by using bundled installer
  • Create a new Python env by using conda or pip and selecting package list
  • Python envs install directory config to create new envs under
  • Updates Python environment selection popup, adds filtering support and link to env management dialog

Python env selection popup
new env select popup

Python env selection popup filtered
filter

Manage Python envs UI, list of existing envs
manage env 1

Manage Python envs UI, env menu
manage env menu

Manage Python envs UI, create new using bundled installer
manage env 2

Manage Python envs UI, create new using conda or pip
manage env 3

Manage Python envs UI, settings (server default env moves from settings dialog to here)
manage env4

@mbektas
Copy link
Member Author

mbektas commented Dec 26, 2023

@krassowski code is still WIP but could you provide feedback on the design & features?

@mbektas mbektas changed the title python env management UI and env selector popup updates Python env management UI and env selector popup updates Dec 26, 2023
@mbektas mbektas marked this pull request as ready for review January 4, 2024 07:24
@krassowski
Copy link
Member

when I type in something which leads to no match, I cannot remove it (backspaces does not work because the input box becomes inactive):

filtering-all-out

IMO the restart and copy buttons are a bit confusing.

  • they represent actions related to current session, but the "x" button nearby represents action on the selector popup
  • the text says "restart session using a different Python env" but they allow to restart using the same env

Maybe these should be two lines, like:

--------------------------------------------------------------------------------
| Current environment: full path    [restart] [copy]                       [x] |
| [a subtle divider]                                                           |
| Restart session with a different Python environment                          |
| [ Type to filter Python paths ]                                              |
--------------------------------------------------------------------------------

@mbektas
Copy link
Member Author

mbektas commented Jan 21, 2024

@krassowski I updated the popup as below
Screenshot 2024-01-21 at 10 23 00 AM

@mbektas mbektas merged commit 41ef6ef into master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants