Improve history overview

[weihwang]

Proposal for full width tabbed history view, which is related to how we may think about push/pull actions. We need a more detailed higher level view of where the latest changes are in local/remote branches. Fly-out full detail on mouse-over provides an easier "browse" experience. Adding a link at the bottom of a default 10 item list gives users a link to the full log if needed.

https://www.figma.com/file/UyNpeQNuTj6Uv74MoEJDh3ji/Git-extension?node-id=517%3A1718

[dhirschfeld]

I was thinking that it might be very cool you you could select two nodes in the history to view the diff between them.

[tgeorgeux]

I put a similar response in #244, what is the upside of fly-out versus just expanding/collapsing each history field?

[weihwang]

@tgeorgeux I think inline expansion would not provide an opportunity to browse via a hover action. I was trying to reduce the amount of clicking to view more details. This is already addressed by revealing more information per history summary.

If we go inline, I think we should only trigger onClick of the summary block. One upside I see for inline could be multiple expansions so you can review more than one commit detail at time. We wouldn't get that with onHover.

[tgeorgeux]

I definately agree with the onclick. I think the fly-out as an overview has merit, but the interactions should stay within the sidebar. @dhirschfeld , I think that diff idea is a great idea! Can you open a separate issue with the 'enhancement' tag, so we can track where this is at and will be in the existing milestones without losing that suggestion?

…

On Fri, Oct 26, 2018 at 4:26 PM William Wang ***@***.***> wrote: @tgeorgeux <https://github.com/tgeorgeux> I think inline expansion would not provide an opportunity to browse via a hover action. I was trying to reduce the amount of clicking to view more details. This is already addressed by revealing more information per history summary. If we go inline, I think we should only trigger onClick of the summary block. One upside I see for inline could be multiple expansions so you can review more than one commit detail at time. We wouldn't get that with onHover. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#245 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVFcwAVKFQr-GjxJRZs5f5FqBSbEndzrks5uo5ougaJpZM4Xc4W-> .

[jaipreet-s]

cc @saulshanabrook

[saulshanabrook]

I would be in favor of the on click over the popout on hover (I find hovering sorta fiddly often).

But am happy to get started on either approach if we have consensus on which to pursue.

[tgeorgeux]

@weihwang @jaipreet-s Do you have additional thoughts on popout vs on-click expanding?

[weihwang]

@tgeorgeux If it's not possible today to create a popout, and the general feedback leans towards inline expansion of details, I think we can start with that version. I have a mock below to expand-on-click. I needed to add more details (username, commit hash) into the collapsed view in this case to create a more seamless "expand" to minimize disrupting content when going to the detail state.

https://www.figma.com/file/UyNpeQNuTj6Uv74MoEJDh3ji/Git-extension?node-id=517%3A1718

[jaipreet-s]

Inline expansion looks better to me as well.

In general, I'd suggest taking this one incrementally

1. Get the "summary view" in place (This'll also unblock the push/pull task)
2. Add "detailed view" on inline expansion
3. Add extra details like the View mode in Terminal option

[tgeorgeux]

Sounds like a good plan to me.

[dhirschfeld]

master/origin strikes me as back-to-front - wouldn't it be more usual to refer to it as remote/branch?

Referring to it in the opposite way to what the cli does might make it more difficult for new users to pick up the command line syntax.

[weihwang]

@dhirschfeld I agree we should align with the expected display. I misrepresented the order of the remote/branch. I'll update the mockup. Thanks!