Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/dependency update #1249

Merged
merged 3 commits into from Aug 10, 2023

Conversation

mfakaehler
Copy link
Contributor

Until issue #1245 and PR #1236 are resolved, I propose to update the dependencies in the README.md and pyproject.toml files to make the current incompatability to jupyterlab 4 explicit.
Please, feel free to make any adjustments.
If you feel it is unnecessary to document this (probably) intermediate issue of incompatibility, please feel free to deny the pull request.

@welcome
Copy link

welcome bot commented Jun 19, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch mfakaehler/jupyterlab-git/hotfix/dependency_update

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfakaehler

One change is unneeded but the README change looks good.

pyproject.toml Outdated
@@ -1,3 +1,3 @@
[build-system]
requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*", "packaging", "setuptools>=40.8.0", "wheel"]
requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*,<4", "packaging", "setuptools>=40.8.0", "wheel"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is not needed because it is use only to build the package and Python requirement >=3.0.0rc13,==3.* is equivalent to >=3.0.0rc13 and ==3.* (see PEP)

Suggested change
requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*,<4", "packaging", "setuptools>=40.8.0", "wheel"]
requires = ["jupyter_packaging~=0.7.9", "jupyterlab>=3.0.0rc13,==3.*", "packaging", "setuptools>=40.8.0", "wheel"]

@mfakaehler
Copy link
Contributor Author

Maybe one should also mark the dependency problem in the conda-forge feedstock?

mfakaehler and others added 2 commits June 20, 2023 17:05
Make imcompatibility to jupyterlab 4 explicit
.prettierignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fcollonval fcollonval merged commit 6eab136 into jupyterlab:main Aug 10, 2023
1 of 6 checks passed
@welcome
Copy link

welcome bot commented Aug 10, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants