New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jupyterlab 1.0.0a3 #342
Conversation
This build is failing because it's trying to |
@gnestor What about waiting till 1.0 is out before upgrading the dependencies here? Do you need this merged before then? |
I have the same question as Saul. This'll break consumers using the last non-pre-release version of JupyterLab, who perhaps only want to use the released versions. (Also thanks for PR!) |
We would release with a pre tag, like the @jupyterlab/github extension: https://www.npmjs.com/package/@jupyterlab/github
It's just currently not working with the 1.0 alpha, so if we merged this and did a pre-release, both alpha and stable users will be able to use it. The only issue is that CI will fail unless we change something in the travis file... 🤔 |
Our setup.py has a dependency on So, I don't think we need to install jupyterlab as a Python dependency in travis. Looking at the file history , we only had the notebook dependency at one point, so it should work just with it. |
Ok cool! Should I just delete the |
Replacing |
Ok I just updated... I have a feeling that travis is still going to fail on the |
Since they are going to release jupyterlab 1.0 in 2 days (jupyterlab/jupyterlab#6504) it would be good to have this merged with the master. |
@set92 I agree. There might be some new breaking API changes that affect jupyterlab-git so I need to take a second look and fix this merge conflict before we merge and publish a new version. |
b525b67
to
fe5a064
Compare
This was merged as part of #374 and released as part of version 0.7. Thanks all! |
Upgrade jupyterlab dependencies to work with 1.0.0a3