Clean up git menu

[mlucool]

Fixes #456

Not in a git repo:

In a git repo:

[fcollonval]

Thank you for this @mlucool.

Three comments:

• Could you use isEnabled rather than isVisible? In JupyterLab it is preferred to not hide element but to disable them when they are not available.
• Could you rephrase Init and Clone to be more verbose for inexperienced users? Taking the same wording than for the buttons (

  jupyterlab-git/src/components/GitPanel.tsx

  Line 332 in 103ea8d

  Initialize a Repository

  ) for instance would be good.
• Could you add the commands:
  • Add remote repository
  • Push to remote
  • Pull to remote

For the two latest, this means creating new commands. But the code is available:

jupyterlab-git/src/components/Toolbar.tsx

Line 306 in 103ea8d

private _onPullClick = (): void => {

Note: change the linked code above to call the new commands rather than the code directly - to ensure behavior homogeneity

[mlucool]

Happy to add more commands/expand wording.

Is there written documentation on the visible vs. enable choice?

[mlucool]

Updated Screen Shots:

[telamonian]

I like it. @mlucool Nice cleanup and improvement

[fcollonval]

Thanks a lot @mlucool

This is really nice indeed. I'm working on a fix for the unit test. Then it will be good to go.

[fcollonval]

Unit tests fixed!

[fcollonval]

@meeseeksdev backport to 0.11.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 0.11.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 4e464ea09277d78b1fe6f7cea2593c34387c63d7

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #699: Clean up git menu'

4. Push to a named branch :

git push YOURFORK 0.11.x:auto-backport-of-pr-699-on-0.11.x

5. Create a PR against branch 0.11.x, I would have named this PR:

"Backport PR #699 on branch 0.11.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.