New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git tag feature #713
Git tag feature #713
Conversation
@fcollonval and @kgryte . Can you review the changes again and help me to complete this feature |
Use SVG icon Reduce code foot print Use new Alert component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisjohn2306 Thank you for this feature.
I simplified the frontend code to:
- Use SVG icon
- Take advantage of the new status bar and alert components instead of using two dialogs.
- Use more homogeneous signature of model method (i.e. not passing the repo path as argument)
3cbfa58
to
4a78619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok after some fight with the latest notebook version and the unit test. This is good to go.
@meeseeksdev backport to 0.11.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Co-authored-by: Chris John <58581644+chrisjohn2306@users.noreply.github.com>
The changes for git tag feature has been added in this PR.
#638 is already existing. But due to some conflict issues the pr has been corrupted. The review comments from that pr has been incorporated here.
The feature discussion is in #588