Backward compatibility for server extension on jupyterhub #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fcollonval
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Thanks @SarunasAzna
Although I'm sad that this is required, it eases the upgrade for most users. So let's merge it.
7 tasks
This was referenced Feb 15, 2021
Merged
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
navn-r
added a commit
to MLH-Fellowship/jupyterlab-git
that referenced
this pull request
Jul 27, 2021
fcollonval
added a commit
that referenced
this pull request
Aug 3, 2021
* Add history context menu button in the file browser (#863) * Add --follow option to Git log command (#864) * Display Git history for selected file (#864) * Apply suggestions from code review Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> * Add styling to selected history file item * Add selected file history for modified files * Add 'No History Found' fallback - Covers git-ignored files edge case * Apply suggestions from code review Improve readability Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> * Fix tests for history (#864) * Add single file log test (#864) Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server extension was not working with jupyterlab 3.0 runned on jupyterhub (version1.2.2, to be more exact helm charts version 0.10.5 from here https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/CHANGELOG.md) though it was working fine with exact docker image runned as standalone container.
I cannot point to the exact problem but the fix itself is copied (and used on another internal server extension) from Voila https://github.com/voila-dashboards/voila.