Build HTML element explicitly instead of creating element

jupyterlab · May 28, 2020 · 0208c48 · 0208c48
1 parent 4d78a94
commit 0208c48
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/packages/rendermime/src/renderers.ts b/packages/rendermime/src/renderers.ts
@@ -486,14 +486,10 @@ function autolink(content: string): string {
       '"\')}\\],:;.!?>]',
     'ug'
   );
-  return content.replace(webLinkRegex, url => {
-    const a = document.createElement('a');
-    a.href = url;
-    a.textContent = url;
-    a.rel = 'noopener';
-    a.target = '_blank';
-    return a.outerHTML;
-  });
+  return content.replace(
+    webLinkRegex,
+    '<a href="$&" rel="noopener" target="_blank">$&</a>'
+  );
 }
 
 /**