Add workspace name in the "Delete" tooltip

jupyterlab · Mar 19, 2024 · 19f3ad8 · 19f3ad8
1 parent bcf8dfc
commit 19f3ad8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/running/src/index.tsx b/packages/running/src/index.tsx
@@ -143,7 +143,7 @@ export class RunningSessionManagers implements IRunningSessionManagers {
 function Item(props: {
   child?: boolean;
   runningItem: IRunningSessions.IRunningItem;
-  shutdownLabel?: string;
+  shutdownLabel?: string | ((item: IRunningSessions.IRunningItem) => string);
   shutdownItemIcon?: LabIcon;
   translator?: ITranslator;
 }) {
@@ -158,7 +158,10 @@ function Item(props: {
   // Handle shutdown requests.
   let stopPropagation = false;
   const shutdownItemIcon = props.shutdownItemIcon || closeIcon;
-  const shutdownLabel = props.shutdownLabel || trans.__('Shut Down');
+  const shutdownLabel =
+    (typeof props.shutdownLabel === 'function'
+      ? props.shutdownLabel(runningItem)
+      : props.shutdownLabel) ?? trans.__('Shut Down');
   const shutdown = () => {
     stopPropagation = true;
     runningItem.shutdown?.();
@@ -232,7 +235,7 @@ function Item(props: {
 function List(props: {
   child?: boolean;
   runningItems: IRunningSessions.IRunningItem[];
-  shutdownLabel?: string;
+  shutdownLabel?: string | ((item: IRunningSessions.IRunningItem) => string);
   shutdownAllLabel?: string;
   shutdownItemIcon?: LabIcon;
   translator?: ITranslator;
@@ -515,7 +518,7 @@ export namespace IRunningSessions {
     /**
      * A string used to describe the shutdown action.
      */
-    shutdownLabel?: string;
+    shutdownLabel?: string | ((item: IRunningSessions.IRunningItem) => string);
 
     /**
      * A string used to describe the shutdown all action.

diff --git a/packages/workspaces-extension/src/sidebar.ts b/packages/workspaces-extension/src/sidebar.ts
@@ -95,7 +95,8 @@ export const workspacesSidebar: JupyterFrontEndPlugin<void> = {
         await model.refresh();
       },
       runningChanged: model.refreshed,
-      shutdownLabel: trans.__('Delete'),
+      shutdownLabel: (item: IRunningSessions.IRunningItem) =>
+        trans.__('Delete %1', item.label() as string),
       shutdownAllLabel: trans.__('Delete All'),
       shutdownAllConfirmationText: trans.__(
         'Are you sure you want to delete all workspaces?'